Domains page shows max 10 domains on child themes

[dandju]

Hello,

I was wondering if anyone has the same issue with the domains page within the client area (/clientarea.php?action=domains) (WHMCS 8.1 GA)?

The customer can only see a maximum of 10 domains. He has 19 active domains in total (which I can see in the admin panel), and when navigating to "/clientarea.php?action=domaindetails&id=<DOMAIN_ID>" I can see the details of the missing domain when entering the ID of the domain manually.

I have then debugged the Smarty template of this page and could see:

$domains Origin: "Smarty object"

Value Array (10)

So for some reason only 10 domains are provided to Smarty/template? Is it a bug? Or should the datatable load the next few domains when clicking next (but next button is disabled)? And datatables says: Showing 1 to 10 of 10 entries.

Thanks for the help and happy new year!

 

[brian!]

5 minutes ago, dandju said:

The customer can only see a maximum of 10 domains.

is the template not showing the pagination at the bottom of the table ??

[dandju]

Hi Brian,

8 minutes ago, brian! said:

is the template not showing the pagination at the bottom of the table ??

No, just the 10 domains and this first page (even when setting it to show 50):

Oh - and it even says 19 in the filter at the left side.

Edited December 31, 2020 by dandju

[brian!]

i'm not seeing that locally....

pagination and filtering is working...

i'm testing on a v8.1b1 dev, and I assume the GA release hasn't broken this... does it work with other languages ??

[dandju]

10 minutes ago, brian! said:

does it work with other languages ??

Just tested with another client and language, still the same:

Also disabled all hooks just to ensure its not related, but still the same.

As I do not know how it is intended to work, it might be an issue with the WHMCS core? As it only provides 10 domains within the $domains variable?

Btw. do you see all those domains in the source code (or in the $domains variable)?

Edited December 31, 2020 by dandju

[brian!]

4 minutes ago, dandju said:

As I do not know how it is intended to work, it might be an issue with the WHMCS core? As it only provides 10 domains within the $domains variable?

a debug window for me is showing all 32 domains in the $domains array - what happens if you use the Six theme instead ??

[dandju]

40 minutes ago, brian! said:

what happens if you use the Six theme instead

Good idea! And indeed, it shows all correctly in the six template?!

I have now noticed that this is related to the child theme - when selecting the "Twenty-One" theme directly, it shows all domains correctly, but when selecting the child theme (which is using the twenty-one as the main template), the domains page shows only 10.

Just for further testing I have removed all files from the child theme folder and just left the theme.yamlfile with the following content:

# Custom Theme Configuration File

name: "Custom Theme"

author: "DD"

config:

   parent: twenty-one

When selecting the "Custom Theme" within the General Settings in WHMCS, the domains page only shows 10 domains?

[dandju]

Update: Also applies to other data tables (eg. invoices, tickets) ... when using the child theme.

[WHMCS ChrisD]

Hello @dandju

Thank you for your report, although I havent seen this issue reported anywhere else I will see if I can replicate this and open a case if needed, I'll let you know in this thread once I have completed testing,

[brian!]

16 hours ago, dandju said:

Update: Also applies to other data tables (eg. invoices, tickets) ... when using the child theme.

now that you mention that it's a child theme, I can see it on all the tables too.

add it to your bug list @xyzulu 🙄

[WHMCS Marcus]

Happy New Year!

We are pleased to announce we have released a Hotfix for this issue: 

 

[brian!]

13 minutes ago, WHMCS Marcus said:

We are pleased to announce we have released a Hotfix for this issue: 

@WHMCS Marcus - small point, but isn't the tag on the hotfix post wrong, it says 8.0_HF, but surely there should be a v8.1 folder of hotfixes (to follow the existing pattern for 8.0, 7.10, 7.9 etc releases) and this hotfix should be in there rather than with the older v8.0 hotfixes and then this tagged 8.1_HF?

[dandju]

Thank you @WHMCS Marcus for the quick update. I can confirm that the workaround has resolved the issue (could not test the patch yet) 👍 

And thank you very much @brian! for the continuous assistance that helped me to narrow down the issue.

Thank you again both of you and a happy new year!

[whattheserver]

@WHMCS Marcus  thanks fore the hotfix it fixed the issue for my site after upgrading to 8.1 via auto updater.

[Ronak Pagi]

Just Add  this line in  theme.yaml   file

properties:
  serverSidePagination: false