8.1 - Twenty-one repeat alert on Password Reset

[MattN]

Just building a new skin based on Twenty-one - and thought I had done something a bit amiss.  On the Password Reset email prompt page at /password/reset - where you are prompted for your email address to start the reset process, if you hit enter (or submit) without putting an email address in, you get 

 

Initially, I thought it was something in my theme layout - so set back to twenty-one to check.

 

Code for the password-reset-email-prompt shows only one call to the Alert routine (as expected):

<div class="mb-4">
    <h6 class="h3">{lang key='pwreset'}</h6>
    <p class="text-muted mb-0">{lang key='pwresetemailneeded'}</p>
</div>

{if $errorMessage}
    {include file="$template/includes/alert.tpl" type="error" msg=$errorMessage textcenter=true}
{/if}

<form method="post" action="{routePath('password-reset-validate-email')}" role="form">
    <input type="hidden" name="action" value="reset" />

    <div class="form-group">.......

 

so checking back up a step, it appears that the "password-reset-container" is where the issue is - as it calls the Alert as well:

<div class="row justify-content-center">
    <div class="card mw-540 mb-4 mt-4">
        <div class="card-body px-md-5 py-5">
            {if $loggedin && $innerTemplate}
                {include file="$template/includes/alert.tpl" type="error" msg="{lang key='noPasswordResetWhenLoggedIn'}" textcenter=true}
            {else}
                {if $successMessage}
                    {include file="$template/includes/alert.tpl" type="success" msg=$successTitle textcenter=true}
                    <p>{$successMessage}</p>
                {else}
                    {if $errorMessage}
                        {include file="$template/includes/alert.tpl" type="error" msg=$errorMessage textcenter=true}
                    {/if}

                    {if $innerTemplate}
                        {include file="$template/password-reset-$innerTemplate.tpl"}
                    {/if}
                {/if}
            {/if}
        </div>
    </div>
</div>

 

[xyzulu]

This issue has been reported and confirmed as being worked on by WHMCS: 

CORE-16022 double validation warning password reset page: 

https://whmcs.community/topic/304324-twenty-one-template-minor-tweaks/?do=findComment&comment=1346483

[MattN]

1 minute ago, xyzulu said:

This issue has been reported and confirmed as being worked on by WHMCS: 

CORE-16022 double validation warning password reset page: 

https://whmcs.community/topic/304324-twenty-one-template-minor-tweaks/?do=findComment&comment=1346483

Thanks!  I must have forgotten seeing it in that thread - I had read through that thread recently.. my bad 🙂 at least its been picked up and being worked on.