CORE-13710 Checkout jQuery Broken (validating wrong CVV)

[gei]

None of our existing clients were able to checkout since we upgraded to 7.8 - even after switching back to the standard six theme and standard_cart.

Eventually we realized that even though the client was using their "existing card" and filling in the existing card CVV field on the checkout page, WHMCS would not let them click Complete Order because it was trying to verify the CVV in the "enter new card" section.

We fixed this by editing templates/orderforms/standard_cart/js/scripts.js and moving this verification:

            if (!jQuery.payment.validateCardCVC(checkoutForm.find('#inputCardCVV').val(), cardType)) {
                checkoutForm.find('#inputCardCVV').showInputError();
                submit = false;
            }

Inside the

if (newOrExisting === 'new') {

conditional. This solved the issue. You then have to re-minify it and modify the scripts.min.js accordingly

Considering this should affect everyone, I'm surprised no one else has pointed it out yet...

[WHMCS John]

Hi @gei,

We've not received a report like this yet. Which payment gateway are you using please?

[gei]

We're using our own custom gateway, but the issue also occurs when using a built in gateway like offline payment. The issue isnt with the gateway itself, it's with the javascript.

[gei]

Is it possible that our own custom gateway is "requiring" the CVV for some reason? If so, how do we remove this requirement. Our payment module is very simple and I don't see any documentation in your gateway module development docs to indicate how to make the CVV an optional field.

This seems to be a similar issue to the one described here:

 

[gei]

FYI WHMCS has confirmed this is a bug:

Thank you for following up. The initial issue (the validation of the CVV field) has been confirmed and opened as case #CORE-13710 with our development team for further investigation and correction. In the meantime, the fix provided in the community thread should be sufficient to work around it.

[WHMCS John]

Hi all,

I'm pleased to advise this has been resolved in the v7.8.2 maintenance update: https://docs.whmcs.com/Changelog:WHMCS_V7.8.2