[not a bug] Incorrect conversion of IDN domain to punycode

[mephist]

Hello,

 

Before WHOIS-lookup it converts to punycode only "sld" part of the domain.

How to reproduce:

1. add this line to whoisservers.php:

".рф|localhost|No entries found"

2. start local netcat to listen on 43 port:

% sudo nc -l 43

3. try to lookup for this domain name "тест.рф"

4. netcat shows the request:

"xn--e1aybc.рф"

 

This public tool (http://www.punycoder.com/) that tld-part must be also converted to ".xn--p1ai"

 

According to my debug, includes/whoisfunctions.php:lookupDomain() calls WHMCS_Domains_Idna()->encode() once, only for sld-part.

[WHMCS Nate]

Hello,

 

Thanks for this report. I spoke with some of our developers, the reason we don't convert the tld is that some registrars do not work when given a converted tld. We decided that the risk of customers seeing domains and then the order failing to go through was not something we would ship.

 

We continue to look for ways to better support idn domains in the product. In the 6.0 branch we have access to pure php modules to handle multibyte strings that make it possible to add support for idn domains throughout the product. We hope to improve this support as the 6.x release cycle continues. If you have feedback on the most important parts of this for your business, we want to collect that information in our feature request system:

 

https://requests.whmcs.com

 

Right now if you need to sell IDN domains, you will need to write new whois servers lines with the punycode tld and have your customers search for it that way.

 

Have a great day,

 

Nate C