Delete Order - cPanel account terminated without any warning!!!

[isixhosting]

Hi,

after xx years I was deleting some old orders in WHMCS. Then I go to WHM/cPanel and WTF??? Some cPanel customers/accounts were not there anymore!!!

It's same issue as described here, so I wan't post it in this thread again:

Now I posted it in bug report to see, what they will say about this. But this is absolutely unacceptable and crazy!!! If I wouldn't have cPanel backups enabled, then the customers accounts/files/websites would be gone for ever!!!

Edited April 17, 2020 by indy0077

[isixhosting]

This is the answer from WHMCS:

Quote

This is expected behaviour, as described in our docs:

Delete Order - Removes the order and everything relating to it - this option should only be used if you want to irrevocably remove the order from the system. This includes deleting the products/services within that order and the associated invoice.

https://docs.whmcs.com/Order_Management#Managing_Orders

 

[brian!]

On 17/04/2020 at 06:44, indy0077 said:

Now I posted it in bug report to see, what they will say about this. But this is absolutely unacceptable and crazy!!! If I wouldn't have cPanel backups enabled, then the customers accounts/files/websites would be gone for ever!!!

i'm not surprised they went down the "expected behaviour" disclaimer, but there is a possible inconsistency in the warnings that the Manage Orders page gives...

if you delete one order via the delete button, you get a longer warning about the consequences...

Quote

Are you sure you want to cancel and delete this order? This will run module termination for any active products/services and delete all related products/services & invoice

but if you delete one or more orders via the "Delete Order" button, the warning is shorter...

Quote

Are you sure you want to delete the selected orders?

assuming both options are terminating services on the server (I haven't tested to confirm), then I would have thought that second warning needs to be changed to be just as explicit... because it implies that it's just removing the order from the WHMCS database and not making any mention of terminating occurring.

Edited April 18, 2020 by brian!

[zitu4life]

On 4/17/2020 at 4:44 AM, indy0077 said:

after xx years I was deleting some old orders in WHMCS. Then I go to WHM/cPanel and WTF??? Some cPanel customers/accounts were not there anymore!!!

About a year ago...I created a post, but now I can not find it, perhaps staffs make it hidden, where my WHMCS production  disappear in seconds due to deleting old orders. It was unbelievable. I have backup active, so it was the only thing my frustration did not make me a little more crazy, or even stop using WHMCS in that time.
But it makes me stronger🤗

A warning message or even checkbox to remove order without deleting everything is really a must.

 

Edited April 18, 2020 by zitu4life

[brian!]

15 minutes ago, zitu4life said:

About a year ago...I created a post, but now I can not find it, perhaps staffs make it hidden, where my WHMCS production  disappear in seconds due to deleting old orders.

 

[zitu4life]

Thanks @brian!, I was searching for it post by post on my page and did not found it🤣 And also realized now that it happens a over 6 months ago🤐

Relating having a warning box message it is really a need and personally sounds really strange that a future requests would be needed for such a important future. Will bring a WHMCS support manager here just to make sure they read this post and perhaps think about it @WHMCS John.

It is not acceptable any-kind of software deleting completely everything when you are working on sales issues, like orders...Deleting everything without any warning related to that. these things sounds strange When we are on working SSH, prompt command or such related software we thing in such thing, but on browser admin interface it is not fair.

 

 

Edited April 18, 2020 by zitu4life

[isixhosting]

Got an another answer from WHMCS support:

Hello,

Thanks for your response, my colleague Dan is no longer on shift, so I will assist you from here.

After further investigation, I find your report to have a certain level of merit. Module termination is ran both when cancelling individual orders, and when bulk cancelling them, however, the warning message is different.

To that end, I have opened up case CORE-14547 with our development team to look at updating the shipped language string for mass cancelling orders to:

$_ADMINLANG['orders']['cancelconfirm'] = "Are you sure you want to cancel the selected orders? This will also run module termination for any active products/services.";

In the meantime, you can also implement this change by creating a language overrides file inside your /admin/lang/ directory, adding the string above to it: https://docs.whmcs.com/Admin_Area#Languages.

 

[bear]

Would it not make far more sense rather than warnings (shifting ones at that), that maybe there should be a checkbox to ask if the associated services should be terminated also? Have it so it won't terminate if it's not checked when you submit? Why not an actual choice to eliminate ambiguity there? 

[brian!]

9 minutes ago, indy0077 said:

Got an another answer from WHMCS support

well done for continuously pushing on this - it's a pity the first Support guy didn't spot the issue. 🙄

2 minutes ago, bear said:

Would it not make far more sense rather than warnings (shifting ones at that), that maybe there should be a checkbox to ask if the associated services should be terminated also? Have it so it won't terminate if it's not checked when you submit? Why not an actual choice to eliminate ambiguity there? 

giving users a choice ? this is ideal a novel concept...

[isixhosting]

11 minutes ago, bear said:

Would it not make far more sense rather than warnings (shifting ones at that), that maybe there should be a checkbox to ask if the associated services should be terminated also? Have it so it won't terminate if it's not checked when you submit? Why not an actual choice to eliminate ambiguity there? 

That's right, but I wan't "discussing" with them any more as they have probably a  "better" solution as these sugested from users of their software.

Edited April 19, 2020 by indy0077

[zitu4life]

8 minutes ago, bear said:

Would it not make far more sense rather than warnings (shifting ones at that), that maybe there should be a checkbox to ask if the associated services should be terminated also? Have it so it won't terminate if it's not checked when you submit? Why not an actual choice to eliminate ambiguity there? 

I am sure they will link CORE-14547 to this post and take the right decision when implementing that. that warning message should be one of those scare you, make you think before click save.

 

 

Edited April 19, 2020 by zitu4life

[drisslebbat]

I think a checkbox letting the admin choose if he wants the product to be terminated or not, will solve this kind of issues.

I faced this issue when a client changed his mind about a VPS server, we canceled the order and the module terminated the server and automatically the licences (cpanel...etc) and we had to reorder all the licences because of that = double payment.

@indy0077, can you plese report that also on your whmcs ticket? this is for the Cancellation and Deletion of the order.

Thank you

[isixhosting]

54 minutes ago, drisslebbat said:

I think a checkbox letting the admin choose if he wants the product to be terminated or not, will solve this kind of issues.

I faced this issue when a client changed his mind about a VPS server, we canceled the order and the module terminated the server and automatically the licences (cpanel...etc) and we had to reorder all the licences because of that = double payment. 

@indy0077, can you plese report that also on your whmcs ticket? this is for the Cancellation and Deletion of the order.

Thank you

I updated my ticket with this:
 

Quote

 

Hi,

here is an another complaint about this issue!:

I think a checkbox letting the admin choose if he wants the product to be terminated or not, will solve this kind of issues.

I faced this issue when a client changed his mind about a VPS server, we canceled the order and the module terminated the server and automatically the licences (cpanel...etc) and we had to reorder all the licences because of that = double payment.

We ALL hope, you will make USEFULL changes to WHMCS to get it working on a logical and "usual" way.

Just follow this thread again:

https://whmcs.community/topic/299408-delete-order-cpanel-account-terminated-without-any-warning/

Thanks

 

and this

Quote

Have in mind that WHMCS is not a PART of cPanel, so you can't remove/delete/or what's ever a third party addon functionality or products. The LOGIC behind this is: It would be the same thing, like due deleting/removing a shared hosting package/plan linked to cPanel will delete/remove the package from my cPanel - I'm sorry, and not just me... That's really a wrong way of thinking.

 

Edited April 19, 2020 by indy0077