moving cron directory config.php question

[Gazza]

moved my cron directory several years ago and my config.php file contains

 

<?php

# Enter path to root WHMCS directory (relative or full)
$whmcspath = '/chroot/home/mydomain/domain/html/clients/';

?>

 

I noticed on a recent upgrade the config.php contains

<?php
/**
* Custom Crons Directory Configuration
*
* This crons folder may be moved to any place above or below the docroot.
*
* We recommend locating it outside the docroot to prevent browser based access.
*
* Upon moving it, you must provide the path to your WHMCS installation to
* allow the cron task files to communicate with the parent WHMCS installation.
*
* To do this, rename this file config.php, then uncomment and enter the full
* path to the WHMCS root directory in the $whmcspath variable below.
*
* You must also provide the appropriate path to the crons folder in the
* $crons_dir variable inside the WHMCS master configuration file.
*
* For more information please see http://docs.whmcs.com/Custom_Crons_Directory
*/

//$whmcspath = '/path/to/whmcs/';

 

it misses a ?> at the end of the code

is this correct or should the ?> it be added

 

thank you in advance for any replies

[Infopro]

Mine has it:

?>

[brian!]

Mine has it:

?>

our v6 dec doesn't - as with many php files with WHMCS, I don't think it matters... a good habit to get into adding it though, but works with or without.

[Gazza]

I am running v6 also

will add it

 

thanks for your replies

[WHMCS John]

Hi,

We don't require the ?> file to user-modifiable files if possible. This is because it can often lead to problems if code, carriage returns or blank spaces are added afterwards. Configuration.php does not require one either.