Domain nameservers not returned correctly

[deepaktsw]

Hello, 

I am facing a weird issue with my WHMC site. 

I am using a custom Domain registrar module, it fetches the nameservers correctly using its API to be double sure I even hardcoded it like this
 

return array(
                'success' => true,
                'ns1' => 'test1.com', 
                'ns2' => 'test2.com',
                'ns3' => '',
                'ns4' => '',
                'ns5' => '',
            );

This returns the name servers from the registrar module . However, on the client area nameservers page in the template the first nameserver, ns1 shifts to ns2 and so on. And ns1 value is simply 'true' and this is why it appears something like this

What is the fix for this? I turned on debug in the template I am getting the values like this - 

 

Value
Array (6)
1 => Array (3)
  num => 1
  label => "Nameserver 1"
  value => true
2 => Array (3)
  num => 2
  label => "Nameserver 2"
  value => "ns40.sbc-dns.com"
3 => Array (3)
  num => 3
  label => "Nameserver 3"
  value => "ns41.sbc-dns.com"
4 => Array (3)
  num => 4
  label => "Nameserver 4"
  value => ""
5 => Array (3)
  num => 5
  label => "Nameserver 5"
  value => ""
6 => Array (1)
  value => ""

 

please help. Thanks

 

[Remitur]

Does it work fine with a different registrar module?

May it be some kind of bug in your client area template?
(but being so the issue should be present with any registrar module you're using...)

 

 

[steven99]

Though the example for registrar modules give 'success' in the return, code I have seen for registrar just has the nameservers.  What happens if you remove the success row?   From what you have provided, it seems WHMCS is trying to use that as nameserver . 

[Remitur]

Found: it's a bug in the sample-registrar-module available on GitHub.
sample-registrar-module is very old, and maybe it worked fine with very old versions of WHMCS... but it's not so anymore.

 I've just opened a pull request on GitHub: https://github.com/WHMCS/sample-registrar-module/pull/12

The fix is very easy: in registrarmodule_GetNameservers function, just delete following line:

'success' => true,

@WHMCS John, please take a look and approve the pull

[RadWebHosting]

18 hours ago, Remitur said:

Found: it's a bug in the sample-registrar-module available on GitHub.
sample-registrar-module is very old, and maybe it worked fine with very old versions of WHMCS... but it's not so anymore.

 I've just opened a pull request on GitHub: https://github.com/WHMCS/sample-registrar-module/pull/12

The fix is very easy: in registrarmodule_GetNameservers function, just delete following line:

'success' => true,

@WHMCS John, please take a look and approve the pull

Wow, nice find.