Domain marked as "active" even if registration is not successfull...

[Walther]

I met following issue, using different registrar modules, so I guess it's an issue of WHMCS itself...

When a user register a domain, and the registration does not complete for any reason (insufficient funds, or some kind of error iduring registration, or whatever...) the domain is marked as "active".

This is misleading for the user ("Why my domain is active but it does not work?!?"), but also for us (having it marked in admin area as "pending" or "pending registration" would make everything easier...)

So I'm here to ask: any trick in order to mark a domain as "pending registration" whenever an error occurs during registration process?

[steven99]

That process creates a handy, albeit it a bit hidden, to do item for the admin to take care of.  Using the AfterRegistrarRegistrationFailed and similar hooks and setting the domain's status to pending via API would be your next step but that requires coding a hook but should be easy for a PHP dev that knows WHMCS . 

[Remitur]

On 11/9/2021 at 10:00 PM, steven99 said:

Using the AfterRegistrarRegistrationFailed and similar hooks and setting the domain's status to pending via API would be your next step but that requires coding a hook 

Good idea.

It should be something like this:

add_hook('AfterRegistrarRegistrationFailed', 1, function($vars) {
  $command = 'UpdateClientDomain';
  $postData = array(
    'domainid' => $vars['domainid'];,
    'status' => 'Pending Registration',
   );
  $results = localAPI($command, $postData);
  logActivity('domain id '.$vars['domainid'].' set as Pending Registration');
}

(but this doesn't work... nothing is reported  in activity log, so I guess that the hook is not triggered... WHMCS docs about this hook is very poor, so it's difficult to understand if the triggering event is different, or if it's a WHMCS bug (it wouldn't be the first time that a hook point does not work...)

[steven99]

You have a ";" hiding after $vars['domainid'];, in the postData array and so is likely silently erroring out. 

Also, the status has to be a valid domain status and that is not one of them.  Change that to just "Pending" and see if that does the trick. 

[Remitur]

15 hours ago, steven99 said:

You have a ";" hiding after $vars['domainid'];, in the postData array and so is likely silently erroring out. 

Nice shot!
It was not the only bug in my (too much quickly written) script.
Here the right code, that I tested and is working fine:

add_hook('AfterRegistrarRegistrationFailed', 1, function($vars) {
  $command = 'UpdateClientDomain';
  $domid = $vars['params']['domainid'];
  $postData = array(
    'domainid' => $domid,
    'status' => 'Pending',
   );
  $results = localAPI($command, $postData);
  logActivity('Domain id '.$domid.' - '.$vars['params']['sld'].'.'.$vars['params']['tld'].' set as Pending Registration');
});

 

[steven99]

I would put the command and array directly in the localAPI to save on lines and would add in the results of the update just in case something funky is going on. 

  logActivity('Domain id '.$domid.' - '.$vars['params']['sld'].'.'.$vars['params']['tld'].' set as Pending Registration: '.$results['result']);