zitu4life Posted March 3, 2020 Share Posted March 3, 2020 (edited) Hello there I am testing how to print WHMCS reports but detect some issues. I will post a print that i have made to pdf. PS: tested on version 7.9.2 Edited March 3, 2020 by zitu4life PS version tested 0 Quote Link to comment Share on other sites More sharing options...
brian! Posted March 4, 2020 Share Posted March 4, 2020 any chance that Printer Friendly Report text is being showing in the header margins - I can't reproduce it other than by showing it in the margin (same with the date top left). the links on the bottom could be removed in the browser before saving/printing to pdf, e.g inspect element and remove the table that they're both in. you could also turn yearspagination to false in the report code and that would remove those two links. I doubt WHMCS would consider these to be bugs (by their unique definition) as the reports have been like this for years, but you could always bug report it and see what they say... perhaps with the v7.10 (yes you read it correctly!) beta coming soon, it may get addressed in that if they think it's an issue. 0 Quote Link to comment Share on other sites More sharing options...
zitu4life Posted March 4, 2020 Author Share Posted March 4, 2020 (edited) 35 minutes ago, brian! said: any chance that Printer Friendly Report text is being showing in the header margins - I can't reproduce it other than by showing it in the margin (same with the date top left). So this mean, it is complicated to remove name branded WHMCS on those reports? 35 minutes ago, brian! said: the links on the bottom could be removed in the browser before saving/printing to pdf, e.g inspect element and remove the table that they're both in. you could also turn yearspagination to false in the report code and that would remove those two links. If WHMCS create reports, and end users of their software needs to do those steps to fix it, their definition are wrong. So if I am using an software and want to fastly print an default reports to present on meeting, and first need to inspect it on browser, or turn some code off that I do not know what mean, to fix their report, for me it is BUG, and for them would be easily to fix it I guess. I will take my chances and report it as a BUG. WHMCS software is not only for coders or developers, but also for end users, so they need to looks at those things too. I would accept name WHMCS branded on top, but those php links clearly needs to be fix on future release, if not in v7.10 but at least in near future, I would be happy if they just open a case regarding that, even if it take some time to be fixed. Let´s bring @WHMCS ChrisD just to make sure they will read this post. Edited March 4, 2020 by zitu4life correct some words 0 Quote Link to comment Share on other sites More sharing options...
brian! Posted March 4, 2020 Share Posted March 4, 2020 1 hour ago, zitu4life said: So this mean, it is complicated to remove name branded WHMCS on those reports? no. that top text, "WHMCS Printer Friendly Report" is the printed page's title, it's hardcoded but it is not coded to be shown on the page (it's in <title> tags) - therefore, that text is being shown in the header/footer of the page in your browser, but you can set your browser not to show header/footers and if you do that, then this specific problem goes away. this isn't really branding... I suppose ideally it should be using a language string so that a user could rename it to suit their own needs (or not there at all), but as I say earlier, whether it is shown is determined by the browser anyway, so not difficult to remove. 1 hour ago, zitu4life said: If WHMCS create reports, and end users of their software needs to do those steps to fix it, their definition are wrong. they're just suggested quick fixes by me to get your situation temporary resolved... at absolute earliest, unless they hotfix it (they won't), then it's going to be a couple of months before v7.10 comes out of beta. 1 hour ago, zitu4life said: WHMCS software is not only for coders or developers, but also for end users, so they need to looks at those things too. i'm tempted to suggest if they really believed that, then they wouldn't have made modifying menus require php coding knowledge. 1 hour ago, zitu4life said: I would accept name WHMCS branded on top, but those php links clearly needs to be fix on future release, if not in v7.10 but at least in near future, I would be happy if they just open a case regarding that, even if it take some time to be fixed. after some quick testing, I think those link outputs are bugs... it does the same in v7.9.1 and v7.8.3, but not v5.3 - so some time between 5.3 and 7.8.3, the bug was introduced - i'll let them figure out when! 1 hour ago, zitu4life said: Let´s bring @WHMCS ChrisD just to make sure they will read this post. it would be easier to just report it as a bug yourself now - include a link to this thread if you think it would help... Chris will be on New Zealand time and asleep for a while yet. 💤 0 Quote Link to comment Share on other sites More sharing options...
zitu4life Posted March 4, 2020 Author Share Posted March 4, 2020 I have reported it as a BUG, lets wait to see what they think about it. Thank you @brian! at least I find out how to disable those header on my google chrome browser. 0 Quote Link to comment Share on other sites More sharing options...
zitu4life Posted March 5, 2020 Author Share Posted March 5, 2020 (edited) 21 hours ago, brian! said: after some quick testing, I think those link outputs are bugs... it does the same in v7.9.1 and v7.8.3, but not v5.3 - so some time between 5.3 and 7.8.3, the bug was introduced - i'll let them figure out when! Many thanks for your time to test it @brian! your inputs clearly were speed up this. Case CORE-14340 were opened on feedback to my ticket, so we can expect in future to have it addressed. "In the meantime, if you really want to get these printed without that, select the appropriate year you wish to generate a report on, then set this line in the annual_income_report.php file to false, then view the printer friendly version of the report:" $reportdata['yearspagination'] = false; Edited March 5, 2020 by zitu4life changed formation to code line 0 Quote Link to comment Share on other sites More sharing options...
brian! Posted March 5, 2020 Share Posted March 5, 2020 7 minutes ago, zitu4life said: Case CORE-14340 were opened on feedback to my ticket. that's good to hear. 🙂 7 minutes ago, zitu4life said: "In the meantime, if you really want to get these printed without that, select the appropriate year you wish to generate a report on, then set this line in the annual_income_report.php file to false, then view the printer friendly version of the report:" $reportdata['yearspagination'] = false; which is what I said... i'm being quoted by Support... my life is complete! 0 Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.