[RESOLVED] Integration code not XHTML valid...

[ChrisGooding]

Hi, just noticed that the integration code supplied within the WHMCS admin area for the Login box is not valid code, and fails w3 validation

 

It lacks tag closing closing eg.....

 

<form method="post" action="http://www.xtrgameservers.com/services/dologin.php"> 
Email Address: <input type="text" name="username" size="50"><br>
Password: <input type="password" name="password" size="20"><br>
<input type="submit" value="Login"> 
</form>

 

Should be....

 

<form method="post" action="http://www.mydomain.com/services/dologin.php"> 
Email Address: <input type="text" name="username" size="50" /><br />
Password: <input type="password" name="password" size="20" /><br />
<input type="submit" value="Login" /> 
</form>

 

I know it is easy to fix, and not exactly a site killer, but thought it best to point it out.

 

[Gears]

Does it pass validation when fixing that?

[ChrisGooding]

It does indeed, for Xhtml 1.0 transitional, wouldn't have posted it otherwise

 

Obviously for xhtml, element tags need to be closed off, either by another closing tag, or within itself using a trailing slash at the end of the initial element tag box

Edited April 14, 2009 by ChrisGooding

[Redsign]

It does indeed, for Xhtml 1.0 transitional

 

For xhtml strict just wrap the inside on the form in a paragraph:

 

<form method="post" action="http://www.mydomain.com/services/dologin.php"> 
<p>Email Address: <input type="text" name="username" size="50" /><br />
Password: <input type="password" name="password" size="20" /><br />
<input type="submit" value="Login" /></p>
</form>

 

[fepixie]

err - wrapping the code supplied in a paragraph will not fix the code errors - i have also noticed the missing close tags on the Integration Code supplied *rolls eyes*

 

<form method="post" action="http://www.domain.co.nz/support/dologin.php">
<input type="hidden" name="token" value="63c654654654649e2558e519e5f79b59be" /> 
Email Address: <input type="text" name="username" size="50"><br>
Password: <input type="password" name="password" size="20"><br>
<input type="submit" value="Login"> 
</form>

 

is supplied - the last 3 <input> tags need a closing / - and so do the <br /> tags

 

same problem in the other integration forms supplied

 

for anyone else having validation problems the input tags should look like...

 

Password: <input type="password" name="password" size="20" /><br />

[zomex]

I will second this Some of us are a bit crazy about validation and this will be a very simple fix for WHMCS.

 

Jack

[Redsign]

err - wrapping the code supplied in a paragraph will not fix the code errors ]

 

It was a year ago, I was young and naive honestly!

[fepixie]

lol - glad you know now - maybe matt/developers will figure it too - there are a few of these type validation errors about...

[aegisdesign]

Not wanting to start an XHTML v HTML debate but it would be good if WHMCS chose one of them and stuck to it. Perhaps it should move to XHTML5

 

Also, I'm getting fed up of removing align="center" and other such ancient tags.

[zomex]

I wouldn't recommend using HTML5 at all. It would be great if we could use it without worrying about compatibility issues but I believe it will be a few years at least before HTML5 will be widely used.

 

Jack

[aegisdesign]

XHTML5 is my starting point on any project today. Provided you provide fallbacks for lesser browsers (IE and mobile browsers mostly) and don't go silly with the new tags, it's pretty much a no brainer. HTML5 provides a pretty nice pattern to follow instead of making up your own DIV id names. I realise that may not be the starting point for many though and I should clarify what I meant. What I was suggesting was a move _toward_ XHTML5 not to using it now as not everyone is perhaps willing to go that far and it has to be integrated with many different website designs.

 

My complaint is mostly that each release of WHMCS sees new templates with tags that have been deprecated for years if not a decade in both HTML and XHTML. v4.4.1 added more div align="right" crap. There's still <font> tags in there even. When you're integrating it into a modern site design, these old tags which fit in neither HTML4.01 or in XHTML 1.0 are a pain to have to fix each time.

 

Many are just pointless. eg. in viewinvoice.tpl there's <font class="unpaid">

 

A <span>is what should be used.

 

It'd save a lot of upgrading time if the templates got rid of these old tags and whoever is changing the templates gets their wrists slapped for adding markup that doesn't validate like align="right".