Delete Order - Removes the order and everything relating to it

[yggdrasil]

I was importing accounts into a new WHMCS 6 installation from a current server with previous billing system.

 

For this I created the order in the customer account set to Active, so it does not create any invoice and it allows me to configure the corresponding cPanel account which exists already.

 

So far so good, but for some reason I did a mistake in some orders and forgot to set them to Active while I created them, so WHMCS now created an invoice for those accounts. I didn't want this as they are paid already so I tried to delete the invoices from the customers accounts but it didn't allow me because there was an order for them. Makes sense.

 

So I tried to cancel the order first and then I deleted the order to start again for this accounts.

 

For my surprise WHMCS deleted the hosting accounts in the cPanel servers when I deleted the orders. What !!!???

 

Please noticed I didn't push the Terminate button on the accounts or deleted them either. WHMCS decided since I deleted the pending order it should delete the corresponding products from the customer account and so as well the hosting account in the servers !!!

 

This is extremely dangerous. No confirmation, nothing. WHMCS should not be deleting accounts unless there is warning and confirmation first. I wanted to remove the orders, yes, but from WHMCS, not the hosting accounts from the servers.

 

Someone should seriously look into this. I understand if some may want this behavior, but I can see many people deleting server accounts by mistake this way. Deleting data in your billing systems should not delete server data unless you check, mark or are warned first, even so there should be a serious confirmation on actions that delete data. There should always be warnings before doing this type of nasty actions which involves data loss.

 

I was not aware deleting the order would also erase the cPanel account. I'm pretty sure this was NOT the case in v5 because I deleted orders in the past and WHMCS didn't terminated the hosting accounts.

[brian!]

I was not aware deleting the order would also erase the cPanel account. I'm pretty sure this was NOT the case in v5 because I deleted orders in the past and WHMCS didn't terminated the hosting accounts.

I could be mistaken, but i'm pretty sure it worked like that with v5 too.

 

http://docs.whmcs.com/Order_Management#Placing_an_Order

 

Cancel Order - Sets the order status to Cancelled, runs module termination for any active products in the order (removing accounts from the server and setting the product status to Cancelled) and also sets the invoice status to Cancelled.

 

Delete Order - Removes the order and everything relating to it - this option should only be used if you want to irrevocably remove the order from the system. This includes deleting the products/services within that order and the associated invoice.

there was some advice from WHMCS John in the thread below that you might find useful for the future...

 

http://forum.whmcs.com/showthread.php?108471-How-to-cancel-order-without-deleting-service

 

Navigate to the order details page (Orders > List All Orders > Click Order ID) and use the status dropdown to change the order's status to cancelled. This will not trigger any module commands.

[yggdrasil]

I don't mind if it will trigger the module, but without a warning?

 

Yes, what I wanted was to delete these orders, since they where wrong and would be otherwise duplicated. From what I see, you can't actually delete an order, just cancel it. Otherwise you are triggering the module command to terminate the product as well. Either way, this is not nice. I just lost some accounts and have a hard time restoring them.

[brian!]

I don't mind if it will trigger the module, but without a warning?

to change that, you basically only have two options.. report it as a bug (but it isn't - so you'd have to hope Nate would see the lack of warning as an issue), or start a feature request.

[yggdrasil]

I don't say executing the module to terminate an account is the bug. The NO warning or notification is the bug.

 

WHMCS should warn the user first, that action is going to also terminate any account on the server. This way you can decide not to click it and first disconnect the module/server before deleting the order, so WHMCS can't delete the account.

 

There is not a single software in 2015 which will not warn a user before executing an action which can't be reversed. Only bad software do this. Take into account, this is something that causes:

 

1. An action which cannot be reverted

2. Data loss

3. No warning what so ever, you just click the delete button, and WHMCS does that, plus deletes accounts on a remote server

 

The delete button is for the order in the GUI. So a user will assume it will delete the order (of course), but he will not assume, it will also delete the account on the server, that delete button has a invisible feature which is not explained or has a warning first.

[brian!]

I don't say executing the module to terminate an account is the bug. The NO warning or notification is the bug.

I know.

 

...but WHMCS tends to treat bugs as the software not doing something that it's supposed to do - that's why I said that Nate would probably state it's not a bug... the software isn't designed to display a warning at that stage, therefore the fact that it doesn't, is correct (in their eyes)... and therefore, no bug.

 

WHMCS should warn the user first, that action is going to also terminate any account on the server. This way you can decide not to click it and first disconnect the module/server before deleting the order, so WHMCS can't delete the account.

i'm not disagreeing with you - what you're suggesting makes perfect sense.

 

all i'm saying is that the WHMCS developers don't read these forums... therefore, you either report it as a bug and hope Nate sees the sense in what you're saying, or you go down the road of submitting a feature request.

[dotifi]

THIS IS SO SO WRONG ! 

 

i also made this same mistake this is june 2020 NO NOTIFICATIONS of data loss etc ! 

 

its unbelievable that such an application would actually allow this ! 

 

and then the horror of hoping your restore works !