[confirmed] Domain Renewal Email Template

[brian!]

the Upcoming Domain Renewal email template contains the following...

 

{if $expiring_domains}{foreach from=$expiring_domains item=domain}{$domain.name} - {$domain.nextduedate} ({$domain.days} Days)
{/foreach}{elseif $domains}{foreach from=$domains item=domain}{$domain.name} - {$domain.nextduedate}
{/foreach}{else}{$domain_name} - {$domain_next_due_date} ({$domain_days_until_nextdue} Days){/if}

when you manually (it probably happens with automated emails too, but they're more difficult to test) send a UDR email to a client about a domain due to expire in the future, it uses the final {else} statement.

 

{else}{$domain_name} - {$domain_next_due_date} ({$domain_days_until_nextdue} Days){/if}

for us, whichever domain we choose that has a renewal date in the future, {$domain_days_until_nextdue} is always equal to 0.

 

the merge field text says that "'Days Until Expiry' and 'Days Until Next Due' will show 0 if the date has passed." - however, the expiry and next due dates for these domains are exactly the same - so the two values should match, but {$domain_days_until_nextdue} gives 0, whilst {$domain_days_until_expiry} gives the correct number of days.

 

therefore, I don't believe that {$domain_days_until_nextdue} is being calculated correctly for future renewals - which means that the resulting emails will not show the correct information... in the short-term, I can work around this by replacing {$domain_days_until_nextdue} with {$domain_days_until_expiry} in the email template.

 

also, and on a related topic, the recent blog post stated that...

 

ICANN now requires sufficient logging of the domain renewal notices so that an audit trail can be provided for regulatory compliance. With that being said, in WHMCS 5.3.12 we've introduced a new dedicated logging system for domain renewal notices which will keep a log of all renewal notices that are sent, along with the date and recipients, and provide an easy way to view and export that information upon request via a new report.

is this feature intentionally designed to log only cron-generated Domain Reminder emails? If not, then there is another bug as it doesn't log manually-sent Domain Reminder emails.

[brian!]

Update: I can confirm that Matt's HotFix: CORE-8351 fixed the {$domain_days_until_nextdue} for me.

 

http://forum.whmcs.com/showthread.php?98503-HotFix-CORE-8351-Domain-renewal-email-template-days-until-nextdue-merge-field-always-zero

[Matt]

Is this feature intentionally designed to log only cron-generated Domain Reminder emails? If not, then there is another bug as it doesn't log manually-sent Domain Reminder emails.

It has been designed to only log emails sent by the automated cron process at this time. We can certainly look into adding the logging of manually sent renewal notice emails too however.

 

Matt