openmind Posted January 30, 2013 Share Posted January 30, 2013 I recently posted in the bugs forum about the PayPal IPN duplicating transactions when the payment has been manually applied. John posted that this would make a good feature request and removed the thread. With respect John this is not a feature request, it's a bug. The IPN service should work correctly in that it shouldn't duplicate paid transactions. 0 Quote Link to comment Share on other sites More sharing options...
brianr Posted January 31, 2013 Share Posted January 31, 2013 Totally with you on this... no reason to remove the thread either. It's a bug. Duplicate transactions entered by an automated method == bug. Doesn't matter if I entered the first manually, or IPN got sent twice (seen that happen too). John, put the thread back. 0 Quote Link to comment Share on other sites More sharing options...
WHMCS Support Manager WHMCS John Posted January 31, 2013 WHMCS Support Manager Share Posted January 31, 2013 Hi, Surely a bug is when the software is not working as designed? As WHMCS is not currently designed to block duplicate transactions/IPNs from payment gateways, it's working as designed. Therefore the best way to change the way it's designed is to submit a feature request. 0 Quote Link to comment Share on other sites More sharing options...
openmind Posted January 31, 2013 Author Share Posted January 31, 2013 Hi,Surely a bug is when the software is not working as designed? As WHMCS is not currently designed to block duplicate transactions/IPNs from payment gateways, it's working as designed. Therefore the best way to change the way it's designed is to submit a feature request. I couldn't disagree more. If an invoice has been marked as paid then the IPN should NOT then add a duplicate payment to the invoice. It should recognise the fact that the invoice has been cleared. Why would someone pay for the same invoice twice??!! 0 Quote Link to comment Share on other sites More sharing options...
brianr Posted January 31, 2013 Share Posted January 31, 2013 I couldn't disagree more. If an invoice has been marked as paid then the IPN should NOT then add a duplicate payment to the invoice. It should recognise the fact that the invoice has been cleared. Why would someone pay for the same invoice twice??!! /boggle And more to your point... Why would someone pay the same invoice multiple times with the same transaction ID/method? Hi,Surely a bug is when the software is not working as designed? As WHMCS is not currently designed to block duplicate transactions/IPNs from payment gateways, it's working as designed. Therefore the best way to change the way it's designed is to submit a feature request. Ok, if that is the stance you want to take, then this is clearly a design flaw that needs to be corrected. In other words, a bug in the design. Reopen the bug report. Honestly, if you want us to open a "feature" request, I'd love to see the marketing on this "feature".... 0 Quote Link to comment Share on other sites More sharing options...
Nathron Posted February 17, 2013 Share Posted February 17, 2013 (edited) InvoicePaid hook just call exit; it shouldn't try and transact again since you restarted the program flow. Of course I don't know if theirs a specific time frame between the double payment. If it just randomly happens way after the first transaction. This works for me though in preventing duplicate payments. From my custom checkout routines. I don't know if you have some modules that make use of this hook though so do an if statement and return instead if the module requests it. Edited February 17, 2013 by Nathron 0 Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.