Chris74 Posted April 11, 2016 Share Posted April 11, 2016 Hi, I recent upgraded form version 5 to 6.3 and I've noticed that reserved UK domains are now showing available - causing us to do a lot of refunds in the last few days. I noticed this is the 6.2 changelog... CORE-8906 - Do not show reserved .uk domains as available in domain checker In version 5 this was already the case and customers needed to use the "claim your uk" module to register reserved uk domains. Can someone possibly confirm that this functionality has been removed again in 6.3? Many thanks. 0 Quote Link to comment Share on other sites More sharing options...
Chris74 Posted April 12, 2016 Author Share Posted April 12, 2016 This is just happening for me then? 0 Quote Link to comment Share on other sites More sharing options...
brian! Posted April 12, 2016 Share Posted April 12, 2016 the WHMCS demo site, using the earlier v6.3 RC1, correctly shows 'whmcs.uk' as being reserved in domainchecker.php... but will allow me to add it to the cart; whereas, if you search via cart.php, it will tell you that the domain is taken and you cannot add it to the cart. I can't test this locally as I haven't upgraded any of the devs to v6.3, let alone a live site. 0 Quote Link to comment Share on other sites More sharing options...
Chris74 Posted April 12, 2016 Author Share Posted April 12, 2016 I might be missing some entries from the language file. If I search for a reserved UK domain it displays just the domain name in place of what might be "congratulations whmcs.uk is available" and the domain can be added to cart..... Ahh yes, the following were missing... $_LANG['domainreserved'] = "Reserved"; $_LANG['domainreserved1'] = "Domain"; $_LANG['domainreserved2'] = "is available, but reserved."; Not sure when these were introduced. So I'm getting the same behaviour as the demo - its saying reserved but allowing it to be added to cart. If they've decided to change this functionality in favour of telling the customer that the domain is reserved -but allowing them to attempt to register it anyway - its going to be a problem because the customer will see the "add to cart" button and just click it anyway. The "domain is available but reserved" notification won't deter them. I do hope it's a bug. 0 Quote Link to comment Share on other sites More sharing options...
brian! Posted April 12, 2016 Share Posted April 12, 2016 Hi Chris, Not sure when these were introduced. So I'm getting the same behaviour as the demo - its saying reserved but allowing it to be added to cart. they're in v6.2.2, so I would guess they were introduced in v6.2 If they've decided to change this functionality in favour of telling the customer that the domain is reserved -but allowing them to attempt to register it anyway - its going to be a problem because the customer will see the "add to cart" button and just click it anyway. The "domain is available but reserved" notification won't deter them. I do hope it's a bug. I suspect it's one of those situations were it's intended behaviour - to be honest, it's a 50/50 call and I can see both sides on this one... on the one hand, if I own 'whmcs.co.uk' (I don't!) and went to your website, I might reasonably want to be able to register 'whmcs.uk'... and with WHMCS as it is now, I can in theory... alternatively, if I don't own 'whmcs.co.uk', but want to register whmcs.uk, domainchecker will let me, but it will be rejected upon registration (as my details will be different to the registrant of whmcs.co.uk) - by which time you've taken my money and will then have to refund. I just tested a quick fix for this that would disable the "Add To Cart" button if a domain result is reserved - that would prevent the customer from adding a reserved domain to the cart... in domainchecker-results.tpl, change ~line 47... <button type="button" onclick="addToCart(this, false, 'register')" class="btn btn-primary btn-sm"> to... <button type="button" onclick="addToCart(this, false, 'register')" class="btn btn-primary btn-sm" {if $searchResults.status eq "reserved"}disabled{/if}> then around ~184, you could change... <button type="button" onclick="addToCart(this, true, 'register')" class="btn btn-default btn-sm"> to... <button type="button" onclick="addToCart(this, true, 'register')" class="btn btn-default btn-sm" {if $result.status eq "reserved"}disabled{/if}> there may be more similar changes required, but they're the two I spotted while testing this on v6.2.2 - this template code looks the same in v6.3, so I assume they would work. for the sake of simplicity, i'm just disabling the buttons as an example - but depending on where you put the {if} statement, you could remove the button entirely, change what the button says or remove the entire specific result if the domain is reserved. 0 Quote Link to comment Share on other sites More sharing options...
Chris74 Posted April 12, 2016 Author Share Posted April 12, 2016 (edited) Very detailed reply there Brian, thank you for taking the time to do that. I was always of the undertanding that all new language additions were added to the end of the language file under a comment detailing the version number. That must not be the case. I'd better do a comparison to make sure I haven't missed anything else. I'm guessing that the new functionality is there to replace the "claim your UK" addon. I'm very grateful for your inclusion of those examples and I will most certainly use them to work something out. I think a detailed explanation in an info box would work. i.e a message telling the client that they should only proceed and add the domain to cart if they have prior ownership of the .co.uk, with a link to a KB article / announcement on reserved .uk domains. I appreciate your input, thanks again. Edited April 12, 2016 by Chris74 0 Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.