CCSupport Posted February 6, 2014 Share Posted February 6, 2014 Hello all, Before I carry out the 'upgrade' to 5.3.3 I have noticed that there's no Patch Set (_patch) download, only the full 5.3.3 download. It says within the members area download section "This is the recommended version for all new installs & upgrades from any earlier version" - So, it reads that it will be a simple upgrade..... However upon inspection the upgrade files are actually a full installation, including the 'install' folder....this worries me as it also includes the Lang/english.php files....which I had to modify to change things like Zip Code to Post Codes etc.....even the 'Slider' form files have been modified to integrate into the frontend better. So, my issue is this, if/when I apply this upgrade....apart from trying to go through each and every file that may have been modified previously it's going to overwrite config bespoke to my setup.... Am I the only one in this position? Current setup is using WHMCS with a Zomex frontend. 0 Quote Link to comment Share on other sites More sharing options...
palmzenith Posted February 6, 2014 Share Posted February 6, 2014 In my opinion, 5.2 and 5.3 is much different in changes for core logic. Then, they won't publish patch for upgrade. If you are at 5.2, I would recommend you not to upgrade at this time, many issues here. 0 Quote Link to comment Share on other sites More sharing options...
Redsign Posted February 6, 2014 Share Posted February 6, 2014 With all the recent patches, I think a full upgrade is definitely the safest route - it ensures you have *everything* up to date and correct.But, as with any release, you'll still need to do a diff/compare on the templates/language files to merge your files. If you're on a Mac you can point FileMerge at your directory and the upgrade files to merge things together - http://smokingapples.com/software/reviews/filemerge-review/ 0 Quote Link to comment Share on other sites More sharing options...
brian! Posted February 6, 2014 Share Posted February 6, 2014 However upon inspection the upgrade files are actually a full installation, including the 'install' folder....this worries me as it also includes the Lang/english.php files....which I had to modify to change things like Zip Code to Post Codes etc.....even the 'Slider' form files have been modified to integrate into the frontend better. with regards to the english.php language files, you shouldn't really modify that file, but use the language overrides technique itstead - http://docs.whmcs.com/Language_Overrides - that way, future similar upgrades won't overwrite your changes. So, my issue is this, if/when I apply this upgrade....apart from trying to go through each and every file that may have been modified previously it's going to overwrite config bespoke to my setup.... yes, but that's always been the way - hence why you need to make a backup before upgrading... if your template is not named the same as any of the existing default templates, then an update wouldn't have any direct impact on your site (unless they rely on something that has been removed from whmcs core files). if you're going to alter the templates / orderforms in any way, rename them (or duplicate and rename), then make the modifications... so when it comes time to upgrade, you won't overwrite your changes... then you can compare your custom template / order form to the new whmcs versions and decide if you need to make any changes to your custom templates to take account of the updated template code. that's what i'll do tomorrow - compare my custom template with the changelog details of the default template changes. i've just upgraded from 5.2.16 to v5.3.3 and all seems to have gone well (as far as I can see - but time will tell)... although why they had to move the fonts folder as it means I now have two of them on the server! in your case, it probably wouldn't do you any harm to wait until Zomex confirm whether they need to make any changes before upgrading. 0 Quote Link to comment Share on other sites More sharing options...
CCSupport Posted February 6, 2014 Author Share Posted February 6, 2014 Thanks for all the speedy replies, very much appreciated! I have changed the language mods and added the Overrides...that's superb! I have also copied and renamed the 'slider' order form folder, gone into WHMCS>General Settings>Ordering and then changed the form template to the renamed one....however for some reason it's now not working. The modified 'slider' template isn't shown and it defaults a different order form.....any ideas on this? I am guessing the guy who changed/modified the slider order form has hardcoded it somewhere 0 Quote Link to comment Share on other sites More sharing options...
brian! Posted February 6, 2014 Share Posted February 6, 2014 perhaps there's a js or image link that's hard coded, but if there is - that's bad coding! is there any possibility that the product group is using its own specified template? that would override the default template settings... setup -> product/services -> product services -> press the edit group button (second from right) for this product group. 0 Quote Link to comment Share on other sites More sharing options...
CCSupport Posted February 6, 2014 Author Share Posted February 6, 2014 I'm thinking bad coding! I have been through the edit group part within each Product group and sadly they are all set to default....so looks like somewhere in some changed coding is the path to the Slider folder. So in essence if I try to copy and rename the Slider folder then change the default Order Form within WHMCS it defaults to what looks like the Modern Order Form. Scratching my head with this one! 0 Quote Link to comment Share on other sites More sharing options...
brian! Posted February 7, 2014 Share Posted February 7, 2014 what did you rename the modified slider directory to? i'm wondering if you gave it a name that whmcs wouldn't like, e.g if you put a space or underscore in the directory name - "modified slider"... as a test, I just renamed "boxes" to "boxes changed" (or "boxes_changed") and WHMCS didn't like either and used "modern" order form template instead. so if that's the case with you, removing any spaces, underscores etc from the directory name should solve the issue - "slidermodified" etc. 0 Quote Link to comment Share on other sites More sharing options...
CCSupport Posted February 7, 2014 Author Share Posted February 7, 2014 You are spot on Brian!! Nice one! I have used an underscore! Interesting that is doesn't like them...but VERY happy now! REALLY appreciate your help with that one....and I have learnt something that I did not know yesterday...that's a good day 0 Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.