Custom Field Values in XML Trouble

[ptomter]

We now getting the values it seems .. from custom fields  - https://whmcs.community/topic/292801-custom-client-fields-values-retrieving/

But when we have this custom in the xml we get  - " Parse error at line [5], column [5]: Extra content at the end of the document "

But if we change this with a value provided by the customer instead ex. 981981981 the the module works perfectly and everything is all good!  So the values retrived is this changed in someway, or added extra information ?! Whmcs Team please provide some insight to this !

 

		";

$clientFields = Client::find($userID)->customFieldValues;

foreach($clientFields AS $field)
{
    
	if (isset($field->customField->fieldName)
		
	and $field->customField->fieldName == "CustomFieldName") 
		    
	{ 	
	
	$xml .=
	
	
	$field->customField->value; // Add ID to XML
			
	
	}	
    
    else
    { 
    return ["error" => "Some Error Message"]; 
    }
}

$xml ="

 

[ptomter]

Anyone have any thoughts regarding this problem?

[steven99]

add a period (".") before the equal  ("=") sign at the end of your code example like you have in getting the field value -- which should be $field->value and not $field->customField->value. 

[ptomter]

Hi Steven,

This has been a long week and also another long day. Yes I tried    $xml .="
but then everything beneth this is new xml for WHMCS suddenly and not a continue of previous XML as it should-.

Before "; at top its just xml and this all works, and are correct, and all beneth $xml .="  is correct, its just when using and getting the value from the custom field its not including .. and working

Is this the best way to get custom field?

[ptomter]

And we are sure that this actually getting the value and not just return NULL ?!

 

";
		
	
foreach($clientFields AS $field)
{
    
if (isset($field->customField->fieldName) 
	
and $field->customField->fieldName == "FieldCustomName") 

{ 
    $xml .= $field->customField->value; // Add ID to XML 
}	
    
    else
    {
        return array("error" => "Some Error Message");

    }
}

$xml .="

 

[steven99]

Will test this further tomorrow or Monday depending on time.