More feedback here, take it FWIW

[twhiting9275]

Something new in 7.1 (didn't see it prior, but it might have been introduced in 7.0) that really needs to be fixed. With error reporting on, it's pretty much useless, in 9/10 cases, especially in parse errors. For example, this gem, time and time again:

 

add_hook('ClientAreaPrimaryNavbar', 1, function (MenuItem $primaryNavbar) { if (!is_null($primaryNavbar->getChild('Open Ticket'))) { $primaryNavbar->removeChild('Open Ticket'); } if (!is_null($primaryNavbar->getChild('Support'))) { $primaryNavbar->getChild('Support') ->addChild('Open Ticket', array( 'label' => Lang::trans('navopenticket'), 'uri' => 'submitticket.php', 'order' => '1', )); } }); function MyCustomTab($vars) { die("Hello"); // $output .= ''; // // return $output; print_r($vars); die(); } add_hook("AdminAreaHeadOutput",1,"MyCustomTab"); 
Parse error: syntax error, unexpected '(', expecting identifier (T_STRING) or variable (T_VARIABLE) or '{' or '$' in /home/user/public_html/whmcs/vendor/whmcs/whmcs-foundation/lib/Config/SettingCollection.php on line 0

Fatal error: Exception thrown without a stack frame in Unknown on line 0

 

Translation:

Great, there's a parse error, somewhere, in one of my files, on one of my lines. Hey, good luck finding it!!!

 

 

 

Can we PLEASE get this rolled back until it's tested and proven to actually be working properly? As of now, it's just costing people time and money here.