db rows not deleted when deleting parent download category

[leemason]

just been cleaning up my whmcs install and found that when you delete a category which includes sub cats and sub downloads it wont remove these from the db.

 

not really sure if this task is left till the cron job or what but im having to manually go in and remove the details.

[Sitepearl]

Are you saying it won't delete the sub categories when you delete a main category? That either means WHMCS doesn't want you to unwittingly delete sub categories or they aren't enforcing referential integrity for another reason.

[leemason]

no everything looks fine in the admin panel, looks like everything is deleted.

 

but when i go into phpmyadmin the cats, and downloads are still there. ive noticed the same as well with some kb articles.

[Sitepearl]

Yeah, either WHMCS doesn't want you to be able to delete hundreds of items without meaning to, or they forgot to enforce referential integrity, or don't even have foreign keys at all.

[leemason]

i have just figured out whats happening.

 

when you delete a parent category, it doesnt delete all inner article or categories.

 

but it also doesnt update the "parentid" in the db rows.

 

so it "looks" like it all been deleted, because it no longer shows in you admin panel, but it is there in the db.

 

my advice is to delete items one at a time, its much easier than sifting through the db like i have tonight.

[Matt]

Thanks for the report. We will check into this.

 

Matt