Api call get password not working

[silverspring]

Hi,

 

i have 3 active whmcs website and i am developing a package to handle some of our needs.

 

I was trying to get users password with http://docs.whmcs.com/API:Get_Clients_Password But it seems not working;

 

I tried for my first website and it is returns wrongs users password.Checked so many times.

 

I tried for last 2 website and api cant find user at all.( Client ID Not Found )

 

I tried for both userid and password nothing has changed.I dont want to create custom api function.So any idea?

[Kian]

Hi,

 

Provide your code and specify if you are using internal or external API

[silverspring]

Hi @klan

 

Here i am using external api, here is my code but i did try with rest clients like postman too.

 

WHMCS::getClientsPassword(12345)

<?php
 public function getClientsPassword($identity,$params=[])
   {
       is_int($identity) ? ($params['userid']=$identity) : ($params['email']=$identity);

       $response= $this->getJson('getclientpassword',$params);

       return !$response ?: $response->body->password;
   }

 

<?php
public function getJson($action,$params=NULL)
   {
       $data=[
           'action'=>$action,
           'responsetype'=>'json'
       ];

       $data = ($params===NULL) ?: array_merge($data,$params);

       $response = Request::get($this->dataUrl($data))
           ->expectsJson()
           ->send();

       if($response->body->result!='success')
       {
           return false;
       }

       return $response;
   }

$this->dataUrl simply generates url like

https://mywebsite.com/includes/api.php?username=<myusername>&password=<myMd5HashedPass>&action=getclientpassword&userid=12345

[silverspring]

Finally fixed.It seems getclientpassword diffrent than others.Above example, as you can see i create query string and its a get request userid must be post.Even so it seems a bit buggy.Without posting userid i can get wrong users password.