Case #4548 still not resolved in v5.3.8

[craigo]

On 22.5.14 I submitted the following bug report:

 

In WHMCS 5.3.7 $options.nameonly and $configoption.optionname output not just the configurable option name as it supposed to (and used to do up to v5.3.6), but it adds also the price.

This affects only $configoption.optiontype 1 and 2 (radio buttons and dropdown), and was probably a result of a change made during the implementation of Case #4089 in v5.3.7 (GetClientsProducts: Fix for configurable options with dropdown and radio button).

Modifications made to configureproduct.tpl, ordersummary.tpl or viewcart.tpl are not the ones affecting this.

 

I had to revert back to v5.3.6 since this messed up my product order form, order summary and cart.

 

ordersummary.tpl has had prior to v5.3.7 $configoption.optionname by default, but it used to output only the name, as it should.

In v5.3.7 it outputs name+price and you can see the price twice in the same line (because there's also $configoption.recurring).

 

viewcart.tpl has had prior to v5.3.7 $configoption.option and output name+price.

But prior to v5.3.7 if you changed this to $configoption.optionname you could have only the option name without the price.

In v5.3.7 you can't because $configoption.optionname outputs name+price as well.

 

configureproduct.tpl has by default $options.name which outputs option name+price.

Prior to v5.3.7 if you changed this to {$options.nameonly} + {$currency.prefix} + {$options.recurring}, you could control and style them separately.

In v5.3.7 you can't anymore because $options.nameonly outputs name+price just as $options.name does.

 

 

On 22.5.14 I received the following reply from John:

 

Thanks for taking the time to file this report. I've been able to replicate this issue on my end as well, and do find this to be an issue within the software. Case #4548 is open with our developers in order to have this resolved for future releases. Unfortunately, I cannot provide an estimated time for completion for this. However, once we resolve cases and push features they are available at our change log, here:

http://changelog.whmcs.com/

I apologize for the inconvenience, and appreciate your patience as we work to resolve this.

If we can be of any more assistance, please don't hesitate to get back in contact.

Kind Regards,

John

Technical Analyst II

 

On 9.7.14 you released v5.3.8, but did not fix this bug... even though you have fixed other bugs reported afterwards, and have found time to add additional features.

 

This bug has completely messed up my product order form, order summary and cart, and I can't understand why you don't immediately fix something you have messed up when you shouldn't have.

 

Don't you have any sense of accountability to your actions and the effect it has on other people's business?

 

After 2 months of waiting, I need a fixed file for it now. Not in the future.

[WHMCS Nate]

Hello,

 

The problem you reported was actually resolved in 5.3.8. I setup a configurable option in my test 5.3.8 installation with a {debug} added and am showing:

 

<code>

configoptions => Array (1)

0 => Array (7)

name => "Test Config"

type => "1"

option => "foo $10.00 USD"

optionname => "foo"

setup => ""

recurring => "$10.00 USD"

qty => 0

</code>

 

Ultimately there were two reports of this issue: 4548 and 4601. In this case we decided to process the work in 4601. You can see 4601 in our changelog:

 

Case #4601 - Remove price from configurable option value in product details

 

Have a great day,

 

Nate C

[craigo]

I will check if in configureproduct.tpl you have reverted back to be able to have {$options.nameonly} + {$currency.prefix} + {$options.recurring} as it used to be in order to continue displaying "foo" "$10" without the currency suffix (USD), because according to what you have written above $options.recurring now shows not just the price number but also the currency prefix and suffix together.