ConfigOptions ccy price updates incorrect

[othellotech]

FYI ...

 

If you make extensive use of configuration options, you'll often end up with "adjusters" - hidden options with -ve values

 

When you go multi-ccy these are not being updated correctly when the rate is input - so a config option of

-£15 is showing as -$15 and -e15 not converted using the rate

 

Positive valued config options appear to be ok

 

| 384 | configoptions | 1 | 3 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 4.00 | 12.00 | 24.00 | 48.00 | 96.00 | 0.00 |

| 4623 | configoptions | 2 | 3 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 6.40 | 19.20 | 38.40 | 76.80 | 153.60 | 0.00 |

 

Negative values are not ok

 

 

| 2057 | configoptions | 1 | 2217 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | -40.00 | -120.00 | -240.00 | -480.00 | -960.00 | -1440.00 |

| 6296 | configoptions | 2 | 2217 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | -40.00 | -120.00 | -240.00 | -480.00 | -960.00 | -1440.00 |

 

Temporary fix... run the following query and adjust through the usual WHMCS config options page

 

select tp.*, tpcos.* from tblpricing as tp, tblproductconfigoptionssub as tpcos where type like "%config%" and (annually < -1 or monthly <-1 or quarterly<-1 or semiannually<-1 or biennially<-1 or triennially<-1) and tp.relid=tpcos.id order by relid,currency

[Matt]

Our current logic check for if a price is set and needs to be converted is if it is greater than 0. This is because we don't want -1 values doubling to -2, which would then re-enable disabled product cycles. But will see what we can do for this.

 

Matt

[othellotech]

Our current logic check for if a price is set and needs to be converted is if it is greater than 0. This is because we don't want -1 values doubling to -2

Yes, needs to be != -1 rather than >0