Jump to content

[NOT A BUG] Minor error with breadcrumbnav


Gav

Recommended Posts

Hi,

 

I recently changed the knowledgebase to use SEO friendly links and noticed a small bug with the links in the nav.

 

Here's the code that is generated:

 

<a href="http://domain.com/index.php">Portal Home</a> > <a href="http://domain.com/knowledgebase.php">Knowledgebase</a> > <a href="knowledgebase/2/Buffering-problems.html">Buffering problems</a>

 

Note the <a href="knowledgebase/2/Buffering-problems.html"> - the link should have a / before it to be <a href="/knowledgebase/2/Buffering-problems.html">

 

The link that's there without a slash in effect links to domain.com/knowledgebase/2/knowledgebase/2/Buffering-problems.html

 

This link also doesn't really need to be there because it only links to the page you're already on anyway but the way it is gives a 404 for anyone that does decide to click on it.

 

And it might also be worth pointing out that it would be better to change > for > to keep things tidy.

Link to comment
Share on other sites

  • 4 weeks later...
  • WHMCS CEO

Hi,

 

There's meant to be a <base href="{$systemurl}"> line in your header template to prevent this problem from occuring as your proposed solution only works if WHMCS is in the root directory of the domain or subdomain and would not work for users with WHMCS in a subfolder. The base href solution works for all.

 

Matt

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use & Guidelines and understand your posts will initially be pre-moderated