Question on why some items are marked taxable

[ffeingol]

Because of the complexity of taxes in our state we have had to utilize the UpdateInvoiceTotal hook to calculate taxes. In the process of doing that we've found an oddity in the database.

 

When we calculate the tax we have to look at each invoice line in the tblinvoiceitems table. For some reason all upgrades and domain registrations are marked as taxable.

 

There appears to be no way to set if domains are taxable or not (they are not in our state) and upgrades should only be taxable if the underlying products are taxable.

 

So far I've just coded around these because our taxable items will never be domains or upgraded but I'm just wondering why those items are automatically marked as taxable.

 

TIA

[thehost5968]

Tax Domains Tick this box to charge tax on domains

 

Tax Rules

[ffeingol]

@thehost5968,

 

Thanks. That one was right in front of my face and I missed it. One down, one to go.

[thehost5968]

when you say "upgraded" do you not mean addons as a upgraded is only charging the difference between 2 plans but a addon it charging a pre-set price.

[ffeingol]

actual upgrades. If you look at tblinvoiceitems (at least in our system) they are type = 'Upgrade' and they are all marked with a taxed column '1' (taxable). We only have to charge tax for internet connections we offer (T1's, Fiber connections etc.) which are not really upgradeable per-se but I hate to write exceptions in the code.

[thehost5968]

I part see what you say but pot anther way if we did not have upgrades then a client would have to cancel there current plan and start a new one so there would be a tax but?

[ffeingol]

I'm not suggesting that they should be taxed or not taxed. What I was suggesting is that the system looks at the product being ugpraded to determine if it should be taxable.

[thehost5968]

It does, I do not charge tax and it does not have tax added? but it would add tax if I charged tax as it is the same as refunding and charging and the client pays only the difference Ie the upgarded price so there is no other way to coded or work out the uprade. look at upgrades being a very small pan that you sell but as it is so small it would just be to hard to list them as a plan. So if whmcs has the "taxed column '1' (taxable)" then this is probable being set from the plan's it is being used there is just now other way to do it.