Comparison Theme Password Strength Bar Movement issue

[tristar]

Hello,

 

if you use comparison theme in order page, did you check password Strength bar movement while registration. I have tested & there is no bar movement observed.

 

Version: WHMCS 5.1.2

 

Lets look at the issue in my side. (please test your own & report your feelings to this thread)

 

PROBLEM:

<script type="text/javascript" src="includes/jscript/pwstrength.js"></script>

this code needs to be moved up.

 

 

quick solution for this:

 

OPEN

 

templates/orderforms/comparison/viewcart.tpl

 

[FIND]

<script type="text/javascript" src="includes/jscript/jqueryui.js"></script>
<script type="text/javascript" src="templates/orderforms/{$carttpl}/js/main.js"></script>
<script type="text/javascript" src="includes/jscript/statesdropdown.js"></script>
<script type="text/javascript" src="includes/jscript/pwstrength.js"></script>
<link rel="stylesheet" type="text/css" href="templates/orderforms/{$carttpl}/style.css" />
<link rel="stylesheet" type="text/css" href="templates/orderforms/{$carttpl}/uistyle.css" />

 

[CHANGE]

 

<script type="text/javascript" src="includes/jscript/jqueryui.js"></script>
<script type="text/javascript" src="includes/jscript/pwstrength.js"></script>
<script type="text/javascript" src="templates/orderforms/{$carttpl}/js/main.js"></script>
<script type="text/javascript" src="includes/jscript/statesdropdown.js"></script>
<link rel="stylesheet" type="text/css" href="templates/orderforms/{$carttpl}/style.css" />

 

Another problem is International Language Problem on Password strenght bar while registration.

 

Screenshot

 

the javascript code(includes/jscript/pwstrength.js) only shows English Language on the template/comparison/viewcart.tpl file at registration page or order page. Template file is not using language translations.

 

Look at the issue:

 

OPEN

template/comparison/viewcart.tpl

FIND

<tr><td colspan="2" align="center"><script language="javascript">showStrengthBar();</script></td></tr>

 

here, showStrengthBar(); code is using for strenght bar movement.

 

lets look at the language translates for showStrengthBar(); in pwstrength.js file.

 

OPEN

 

includes/jscript/pwstrength.js

 

PART 1

 

FIND

 

 

function showStrengthBar() {
   document.write('<table align="center"><tr><td>Password Strength:</td><td width="102"><div id="pwstrengthpos" style="position:relative;float:left;width:0px;background-color:#33CC00;border:1px solid #000;border-right:0px;"> </div><div id="pwstrengthneg" style="position:relative;float:right;width:100px;background-color:#efefef;border:1px solid #000;border-left:0px;"> </div></td><td><div id="pwstrength">Weak</div></td></tr></table>');
}

 

Password Strength word is not use international translates, just show english word in order page. We have to change manually (why?)

 

PART 2

 

FIND

jQuery("#newpw").keyup(function () {
       var pwvalue = jQuery("#newpw").val();
       var pwstrength = getPasswordStrength(pwvalue);
       jQuery("#pwstrength").html("Strong");
       jQuery("#pwstrengthpos").css("background-color","#33CC00");
       if (pwstrength<75) {
           jQuery("#pwstrength").html("Moderate");
           jQuery("#pwstrengthpos").css("background-color","#ff6600");
       }
       if (pwstrength<30) {
           jQuery("#pwstrength").html("Weak");
           jQuery("#pwstrengthpos").css("background-color","#cc0000");
       }
       jQuery("#pwstrengthpos").css("width",pwstrength);
       jQuery("#pwstrengthneg").css("width",100-pwstrength);

 

Strong, Moderate, Weak words are not use international translates, just show english word. We have to change manually (why?)

 

This code needs to be revised again.

 

If you have same problem please share your feelings.

thanks for your attention.

Edited July 23, 2012 by tristar