Found a bug in 3.2.1

[kurbot]

Hello, i found a bug on the creditcard form upon checkout with version 3.2.1

 

There is a section for choosing the credit card type (visa, mastercard, etc) which is coded like this under the template creditcard.tpl

 

<select name="cctype">

{foreach key=num item=cardtype from=$acceptedcctypes}

{$cardtype}

{/foreach}

</select>

 

well it doesnt provide a select form without the <option> tags

 

so i rewrote it to

 

<select name="cctype">

{foreach key=num item=cardtype from=$acceptedcctypes}<option>

{$cardtype}</option>

{/foreach}

</select>

 

also on the clientareadetails.tpl similar error for updating card information.

 

it currently reads:

 

<select name="cctype">

{foreach key=num item=cardtype from=$acceptedcctypes}

<option>

{$cardtype}

{/foreach}

</option>

</select>

 

again a simple problem being the foreach is on the wrong side of the end option bracket.

 

i changed to:

 

<select name="cctype">

{foreach key=num item=cardtype from=$acceptedcctypes}<option>

{$cardtype}</option>

{/foreach}

</select>

 

Both work perfectly now, but lost me a weeks in sales cause i did not know it was not working untill i tested a new product.

 

Both of these are incredicbly simple fixes, and i can understand how they were overlooked.

 

Just wanted to give the heads up.

 

Thanks

[CSNM-Carl]

It's working fine for me as it is?

[Nathan123]

It's working fine for me as it is?

 

Works fine for me aswell?

 

Nathan

[Matt]

To confirm, this is not a bug in the default templates. Not sure how you got an error in yours.