Jump to content
Sign in to follow this  
Kian

Inconsistent ClientEdit / Tax Exempt

Recommended Posts

This is not a v8 bug/problem but it should be addressed asap.

whmcs-tax-exempt.png.b26ec7735c5804b082dcd45e0c8c7ef7.png

Clicking this link sends a post to edit client details but it doesn't execute ClientEdit hook point. This is a big problem for invoicing. Changes to Tax Exempt status require a lot of custom checks (eg. VIES, Intra/Extra EU, special tax regions, Split Payment, business type...). That's not a problem as long as we have things like ClientAdd and ClientEdit hook points but clicking on Yes/No leaves us with nothing to use. There's no way for us to detect this change and perform our checks. This is causing a lot of billing errors from years.

The question is pretty simple. I quote «ClientEdit Executes when a client is edited.» When you change Tax Exempt you are actually editing customer. If I do it from "Profiles" tab "ClientEdit" hook triggers as normal. If I do the same from the Yes/No it doesn't (leaving me with lot of billing errors to fix manually).

Share this post


Link to post
Share on other sites
11 minutes ago, Kian said:

This is not a v8 bug/problem but it should be addressed asap.

whmcs-tax-exempt.png.b26ec7735c5804b082dcd45e0c8c7ef7.png

Clicking this link sends a post to edit client details but it doesn't execute ClientEdit hook point. This is a big problem for invoicing. Changes to Tax Exempt status require a lot of custom checks (eg. VIES, Intra/Extra EU, special tax regions, Split Payment, business type...). That's not a problem as long as we have things like ClientAdd and ClientEdit hook points but clicking on Yes/No leaves us with nothing to use. There's no way for us to detect this change and perform our checks. This is causing a lot of billing errors from years.

The question is pretty simple. I quote «ClientEdit Executes when a client is edited.» When you change Tax Exempt you are actually editing customer. If I do it from "Profiles" tab "ClientEdit" hook triggers as normal. If I do the same from the Yes/No it doesn't (leaving me with lot of billing errors to fix manually).

Thanks for raising this issue, I'm going to investigate this now and will update the thread shortly.

Share this post


Link to post
Share on other sites

Hi @Kian

I have been able to replicate this behaviour, and it does look like it would make sense for the ClientEdit hook to be fired when using the Tax Exempt shortcut link.

I have now raised case #CORE-15138 for our developers to review this for future versions.

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Sign in to follow this  

  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use & Guidelines and understand your posts will initially be pre-moderated