TheHostingHeroes Posted May 7, 2013 Share Posted May 7, 2013 upload to /includes/ ccfunctions.zip 0 Quote Link to comment Share on other sites More sharing options...
alinford Posted May 7, 2013 Author Share Posted May 7, 2013 They sent that to me as well, but I thought it was for another issue I am having with a customization they did for me because this file breaks that I will contact them. Glad there now seems to be a fix. 0 Quote Link to comment Share on other sites More sharing options...
pjs32 Posted May 7, 2013 Share Posted May 7, 2013 upload to /includes/ Thank you Chris - that fixed the problem! 0 Quote Link to comment Share on other sites More sharing options...
And then there was one les Posted May 7, 2013 Share Posted May 7, 2013 If this is fixed maybe the forum staff can lock the thread and mark it "fix included" 0 Quote Link to comment Share on other sites More sharing options...
DF-Duncan Posted May 7, 2013 Share Posted May 7, 2013 Seems that file does not fix it for us, same problem and when running a manual cron the last thing it does is: Starting Processing Credit Card Charges - Credit Card Payments Processed (x Captured, x Failed) It should be doing the below: Starting Processing Credit Card Charges - Credit Card Payments Processed (x Captured, x Failed) Starting Processing Invoice Reminder Notices - Sent x Reminders Starting Processing Domain Renewal Notices - Sent x Notices Starting Processing Overdue Suspensions - Processed x Suspensions Starting Performing Automated Fixed Term Service Terminations - Processed x Terminations Starting Auto Closing Inactive Tickets Starting Processing Email Marketer Rules Completed Cron Job Hooks Run... Starting Database Backup Backup Complete... Goodbye Therefore it breaks/stops right after running the credit card capture's 0 Quote Link to comment Share on other sites More sharing options...
And then there was one les Posted May 8, 2013 Share Posted May 8, 2013 Starting Database Backup Mine was halting at email notices. and now it halts at the point i have quoted. Im not bothering with that, i dont backup by whmcs anyway but i would still like to have the cron complete its tasks. Have you checked your modules/hooks are upto date? Hooks from my previous version were the breaker for me. 0 Quote Link to comment Share on other sites More sharing options...
DF-Duncan Posted May 8, 2013 Share Posted May 8, 2013 Mine was halting at email notices. and now it halts at the point i have quoted. Im not bothering with that, i dont backup by whmcs anyway but i would still like to have the cron complete its tasks. Have you checked your modules/hooks are upto date? Hooks from my previous version were the breaker for me. We removed all Hooks, 100% def not the cause for us in 2 different installs. 0 Quote Link to comment Share on other sites More sharing options...
And then there was one les Posted May 8, 2013 Share Posted May 8, 2013 We removed all Hooks, 100% def not the cause for us in 2 different installs. What about modules? are those that you have in use all up to date? its possible your card processors module needs looking at. 0 Quote Link to comment Share on other sites More sharing options...
DF-Duncan Posted May 8, 2013 Share Posted May 8, 2013 What about modules? are those that you have in use all up to date? its possible your card processors module needs looking at. When we do an upgrade, we use all new files from the update archive, nothing is old. We unzip into a new archive, and move this archive from a test environment to a live environment. No chance of old files/modules. We do not use custom modules, it is all WHMCS files. There is nothing wrong with the card processing module as this works 100% with the non working php file. As mentioned above, it is a fault to which we already have a ticket open which Mat is looking into, although no reply from it for over 1 week. 0 Quote Link to comment Share on other sites More sharing options...
And then there was one les Posted May 8, 2013 Share Posted May 8, 2013 When we do an upgrade, we use all new files from the update archive, nothing is old. We unzip into a new archive, and move this archive from a test environment to a live environment. No chance of old files/modules. We do not use custom modules, it is all WHMCS files. There is nothing wrong with the card processing module as this works 100% with the non working php file. As mentioned above, it is a fault to which we already have a ticket open which Mat is looking into, although no reply from it for over 1 week. Okay i understand what you are saying about the upgrades, Although an upgrade download is no guarantee that there are no old modules in it. I just had to update the whmcs GoCardless module with GoCardless own module today to fix a problem, The broken module was from a freshly installed 5.2.4 upgrade that i downloaded a couple of days ago. I'm just trying to rule out issues that could be a problem for you. It may not be the issue at all but its worth looking into at the very least. 0 Quote Link to comment Share on other sites More sharing options...
DF-Duncan Posted May 8, 2013 Share Posted May 8, 2013 I appreciate your help, we really do, but it appears not to be either of these, as we have tried in our dev install as well with all fresh 5.2.4 files. 0 Quote Link to comment Share on other sites More sharing options...
And then there was one les Posted May 8, 2013 Share Posted May 8, 2013 No problem i hope you get it sorted soon. 0 Quote Link to comment Share on other sites More sharing options...
Troy Posted May 8, 2013 Share Posted May 8, 2013 The patch posted earlier in this thread seems to have fixed ours, for what it's worth. 0 Quote Link to comment Share on other sites More sharing options...
And then there was one les Posted May 16, 2013 Share Posted May 16, 2013 Troy meant this one, to save you all searching the thread. http://forum.whmcs.com/attachment.php?attachmentid=4643&d=1367916119 0 Quote Link to comment Share on other sites More sharing options...
pjs32 Posted July 29, 2013 Share Posted July 29, 2013 You will need to use the patch again for the latest version - 5.2.7 You would have thought they would have included it within the latest build - whmcs is becoming a bit of a shambles.. 0 Quote Link to comment Share on other sites More sharing options...
TheHostingHeroes Posted July 29, 2013 Share Posted July 29, 2013 it'll be fixed in 5.3 but not 5.2... not sure why they never included it in 5.2.7 which was a bug fix release. v.odd 0 Quote Link to comment Share on other sites More sharing options...
Troy Posted July 29, 2013 Share Posted July 29, 2013 So this fix never got rolled into 5.2? Are we positive ccfunctions.php hasn't seen any other changes that the patch will remove? 0 Quote Link to comment Share on other sites More sharing options...
DF-Duncan Posted July 29, 2013 Share Posted July 29, 2013 In the 5.2.7 ccfunctions.php broke our daily billing again. ie it would only process new invoices, not overdue invoices. Whene we uploaded the ccfunctions.php fix we got earlier in this thread it worked again. I do not understand how a broken ccfunctions.php is getting sent out in new stable releases, it seems rather odd. I would have assumed when a patch is given to something broken, on the very next release, the file is updated. It is just another one of the things we have to check on an update to make sure things work as they should. 0 Quote Link to comment Share on other sites More sharing options...
WHMCS Chris Posted July 29, 2013 Share Posted July 29, 2013 it'll be fixed in 5.3 but not 5.2... not sure why they never included it in 5.2.7 which was a bug fix release. v.odd v5.2.7 was only create to resolve regressive behavior within the TSR (v5.2.6) that was released. 0 Quote Link to comment Share on other sites More sharing options...
Troy Posted July 29, 2013 Share Posted July 29, 2013 Chris, Can you confirm that no new code has been added to ccfunctions.php that is missing from the patch? i.e. are we completely safe re-applying the patch to 5.2.7? 0 Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.